WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#38429 closed enhancement (fixed)

Add a constructor to WP_REST_Settings_Controller

Reported by: soean's profile Soean Owned by: rachelbaker's profile rachelbaker
Milestone: 4.7 Priority: normal
Severity: normal Version: 4.7
Component: REST API Keywords: has-patch
Focuses: Cc:

Description

The classWP_REST_Settings_Controller overrides the properties namespace and rest_base.
Instead, the properties should be set by a constructor.

Attachments (2)

38398.2.patch​ (22.8 KB) - added by Soean 10 years ago.
Adds a constructor to WP_REST_Settings_Controller.
38429.patch​ (714 bytes) - added by Soean 10 years ago.
Adds a constructor to WP_REST_Settings_Controller.

Download all attachments as: .zip

Change History (6)

@Soean
10 years ago

Adds a constructor to WP_REST_Settings_Controller.

@Soean
10 years ago

Adds a constructor to WP_REST_Settings_Controller.

#1 @Soean
10 years ago

  • Keywords has-patch added

Ups. 38429.patch is the right patch.

#2 @Soean
10 years ago

All the other controller classes have a constructor to set the properties. So we should use it in WP_REST_Settings_Controller too, to be consistent in the classes.

#3 @rachelbaker
10 years ago

  • Owner set to rachelbaker
  • Resolution set to fixed
  • Status changed from new to closed

In 38954:

REST API: Add constructor to the WP_REST_Settings_Controller class.

Provides consistency with the other API endpoint controller classes.

Props Soean.
Fixes #38429.

#4 @netweb
10 years ago

  • Milestone changed from Awaiting Review to 4.7
Note: See TracTickets for help on using tickets.