Complete test coverage for current_user_can_for_site()

[johnbillion]

In Tests_User_Capabilities, all roles and capabilities are tested using current_user_can(). They should all be tested using current_user_can_for_site(), too.

[desrosj]

Marking good-first-bug for someone that would like to dive into writing unit tests.

[santilinwp]

I'v duplicated the calls in one function: test_subscriber_cant_edit_posts with the desired result, but then I have added a new function to test that an editor CAN edit their posts but no others in another site, but it looks like current_user_can_for_blog takes the current site when the other site doesn't exist.

I'll attach the diff and the output.

[santilinwp]

Replying to santilinwp:

I'v duplicated the calls in one function: test_subscriber_cant_edit_posts with the desired result, but then I have added a new function to test that an editor CAN edit their posts but no others in another site, but it looks like current_user_can_for_blog takes the current site when the other site doesn't exist.

I'll attach the diff and the output.

Digging a little bit more in the code I've learnt that current_user_can_for_blog just disregards the $blog_id parameter if not is_multisite, so the test is allright.

[santilinwp]

I understand that the way to go is duplicate most of the functions to make multisite and not multisite versions, like in the attached example.

[santilinwp]

An extended patch which demostrates the duplicating of tests (multisite and not multisite)

[michaelwp85]

While looking for a good first ticket to contribute I looked at this one.

I think this ticket can be closed, and marked as done. Seeing current_user__can_for_blog has been deprecated: * @deprecated 6.7.0 Use current_user_can_for_site() instead. I don't know the test coverage, but there are multiple tests for current_user_can_for_site.

[sachinrajcp123]

Added current_user_can_for_blog() assertions to Tests_User_Capabilities for full coverage.

[johnbillion]

Thanks so much for the patch @sachinrajcp123 . Would you like to ​open a GitHub pull request with those changes please so the test suite can run?

Also the function has been deprecated since this ticket was opened so I've changed the title. The preferred function name is now current_user_can_for_site().

[johnbillion]

Oh you know what, @michaelwp85 is correct. This function actually has test coverage now since #45197. Thanks everyone!

Adds test coverage for current_user_can_for_site() and user_can_for_site().
Replaces remaining uses of deprecated current_user_can_for_blog() in tests.

See: https://core.trac.wordpress.org/ticket/38433