Complete test coverage for current_user_can_for_blog()

[johnbillion]

In Tests_User_Capabilities, all roles and capabilities are tested using current_user_can(). They should all be tested using current_user_can_for_blog(), too.

[desrosj]

Marking good-first-bug for someone that would like to dive into writing unit tests.

[santilinwp]

I'v duplicated the calls in one function: test_subscriber_cant_edit_posts with the desired result, but then I have added a new function to test that an editor CAN edit their posts but no others in another site, but it looks like current_user_can_for_blog takes the current site when the other site doesn't exist.

I'll attach the diff and the output.

[santilinwp]

Replying to santilinwp:

I'v duplicated the calls in one function: test_subscriber_cant_edit_posts with the desired result, but then I have added a new function to test that an editor CAN edit their posts but no others in another site, but it looks like current_user_can_for_blog takes the current site when the other site doesn't exist.

I'll attach the diff and the output.

Digging a little bit more in the code I've learnt that current_user_can_for_blog just disregards the $blog_id parameter if not is_multisite, so the test is allright.

[santilinwp]

I understand that the way to go is duplicate most of the functions to make multisite and not multisite versions, like in the attached example.

[santilinwp]

An extended patch which demostrates the duplicating of tests (multisite and not multisite)