WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#38447 closed defect (bug) (fixed)

Twenty Seventeen: Formatting in table

Reported by: karmatosed Owned by: davidakennedy
Milestone: 4.7 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: ui-feedback has-screenshots has-patch
Focuses: Cc:

Description

This could be a design decision but feels weird to me as offset. The tables show this on both Chrome and Firefox in testing:

https://cldup.com/_bXxw-3ENv.png

Attachments (5)

38447.diff (401 bytes) - added by snacking 3 years ago.
The CSS File fix for the table padding issue
screencapture-localhost-wordpress-core-src-index-php-test-1477222557441.png (73.1 KB) - added by snacking 3 years ago.
Mobile version after fix
screencapture-localhost-wordpress-core-src-index-php-test-1477222510874.png (321.5 KB) - added by snacking 3 years ago.
Desktop version after fix
38447.2.diff (523 bytes) - added by snacking 3 years ago.
This is the updated fix according to the note by the last comment with the padding removed only from the left side
38447.3.diff (2.0 KB) - added by laurelfulford 3 years ago.

Download all attachments as: .zip

Change History (15)

#1 @karmatosed
3 years ago

  • Milestone changed from Awaiting Review to 4.7

#2 @melchoyce
3 years ago

Yeah, shouldn't be any left-padding in cells — will take a look.

#3 @kamena
3 years ago

I would like to work on this one, but @karmatosed what exactly is the problem here? It looks okay to me.

#4 @karmatosed
3 years ago

That's awesome @kamena. As per @melchoyce's comment, do you see the left padding in the cells?

@snacking
3 years ago

The CSS File fix for the table padding issue

#5 @snacking
3 years ago

  • Keywords has-screenshots has-patch added

#6 @xavortm
3 years ago

First of all, @snacking welcome here, I see it's your first commit

About the patch - from the comment above "Yeah, shouldn't be any left-padding in cells — will take a look."
Meaning - you should still be having the right padding. The issue of this can be seen in the mobile view screenshot you posted.

@snacking
3 years ago

This is the updated fix according to the note by the last comment with the padding removed only from the left side

#7 @karmatosed
3 years ago

Unfortunately the padding seems to have been lost on headers now:

https://cldup.com/VzN_CQfxRn.png

What we need is just the padding to be removed from those out of line.

#8 @davidakennedy
3 years ago

To clarify, is this happening on desktop, mobile or both? I'm not seeing it in Chrome, Firefox or Safari.

#9 @laurelfulford
3 years ago

I created a riff on @snacking's 38447.2.diff - it:

  • Removes the left padding on the first cell in a row, and the right padding on the last cell in each row - the padding is still there between cells, so the contents don't meet.
  • Does the opposite for RTL.
  • Updates the editor styles (which didn't include the most up-to-date editor styles).

#10 @davidakennedy
3 years ago

  • Owner set to davidakennedy
  • Resolution set to fixed
  • Status changed from new to closed

In 38963:

Twenty Seventeen: Make table styles more consistent

  • Removes the left padding on the first cell in a row, and the right padding on the last cell in each row - the padding is still there between cells, so the contents don't meet.
  • Does the opposite for RTL, and fixes some spacing issues.
  • Updates the editor styles to match.

Props laurelfulford, snacking.

Fixes #38447.

Note: See TracTickets for help on using tickets.