WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#38448 closed defect (bug) (fixed)

Twenty Seventeen: Should skip to go to the title not the post content?

Reported by: karmatosed's profile karmatosed Owned by: davidakennedy's profile davidakennedy
Milestone: 4.7 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: ui-feedback has-patch
Focuses: Cc:

Description

I found this on all browsers to seems expected behaviour, maybe a design decision. I felt though as using the theme in testing that having it skip so far feels a little odd.

https://cldup.com/NuRJWoH4TV.gif

Attachments (1)

38448.diff​ (721 bytes) - added by tywayne 8 years ago.

Download all attachments as: .zip

Change History (4)

#1 @melchoyce
8 years ago

Looks like a regression — this was fixed in ​https://github.com/WordPress/twentyseventeen/pull/274.

@tywayne
8 years ago

#2 @tywayne
8 years ago

  • Keywords has-patch added

Patch should fix the regression based on the PR linked above. The main problem was that the menuTop variable lost it's initial definition of 0, so all future subtractions were failing.

#3 @davidakennedy
8 years ago

  • Owner set to davidakennedy
  • Resolution set to fixed
  • Status changed from new to closed

In 38886:

Twenty Seventeen: Fix smooth scrolling skip link

The link was scrolling too far. The main problem was that the menuTop variable lost it's initial definition of 0, so all future subtractions were failing.

Props tywayne.

Fixes #38448.

Note: See TracTickets for help on using tickets.