Context Navigation

← Previous Ticket
Next Ticket →

#38448 closed defect (bug) (fixed)

Twenty Seventeen: Should skip to go to the title not the post content?

Reported by:	karmatosed	Owned by:	davidakennedy
Priority:	normal	Milestone:	4.7
Component:	Bundled Theme	Version:
Severity:	normal	Keywords:	ui-feedback has-patch
Cc:		Focuses:

Description

I found this on all browsers to seems expected behaviour, maybe a design decision. I felt though as using the theme in testing that having it skip so far feels a little odd.

Attachments (1)

38448.diff (721 bytes ) - added by tywayne 10 years ago.

Download all attachments as: .zip

Change History (4)

#1 @melchoyce
10 years ago

Looks like a regression — this was fixed in https://github.com/WordPress/twentyseventeen/pull/274.

@tywayne
10 years ago

Attachment 38448.diff added

#2 @tywayne
10 years ago

Keywords has-patch added

Patch should fix the regression based on the PR linked above. The main problem was that the menuTop variable lost it's initial definition of 0, so all future subtractions were failing.

#3 @davidakennedy
10 years ago

Owner set to davidakennedy
Resolution → fixed
Status new → closed

In 38886:

Twenty Seventeen: Fix smooth scrolling skip link

The link was scrolling too far. The main problem was that the menuTop variable lost it's initial definition of 0, so all future subtractions were failing.

Props tywayne.

Fixes #38448.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core