Opened 8 years ago
Closed 8 years ago
#38449 closed defect (bug) (fixed)
Twenty Seventeen: clean up excessive escaping in color-patterns.php
Reported by: | celloexpressions | Owned by: | davidakennedy |
---|---|---|---|
Milestone: | 4.7 | Priority: | normal |
Severity: | normal | Version: | 4.7 |
Component: | Bundled Theme | Keywords: | has-patch |
Focuses: | Cc: |
Description
For some reason, the $hue
and $saturation
variables have esc_attr
every single time they appear in the CSS, making the CSS virtually unreadable. If these variables need to be escaped they should be escaped once when they're set. absint
would be more appropriate for both anyway, as they're positive integers, then a %
is appended to the saturation var. This is essentially a CSS file and the PHP pieces need to be as minimal/efficient as possible for readability.
Patch should wait for #38389 to avoid conflicting patches.
Attachments (2)
Change History (4)
Note: See
TracTickets for help on using
tickets.
absint used when fetching value. esc_attr removed from each instance of using the variables.