WordPress.org

Make WordPress Core

Opened 10 years ago

Closed 8 years ago

#3845 closed enhancement (wontfix)

WPCON next to WPINC

Reported by: Nazgul Owned by: Nazgul
Milestone: Priority: normal
Severity: normal Version: 2.2
Component: Optimization Keywords: has-patch
Focuses: Cc:

Description

We have WPINC defined, which points to wp-includes. It seems logical to also define a WPCON that points to wp-content.

Attachments (4)

3845.diff (10.9 KB) - added by Nazgul 10 years ago.
3845refresh.diff (11.2 KB) - added by Nazgul 9 years ago.
3845refresh2.diff (10.7 KB) - added by Nazgul 9 years ago.
3845refresh3.diff (11.4 KB) - added by Nazgul 9 years ago.
With DD32's constructor suggestion

Download all attachments as: .zip

Change History (16)

@Nazgul
10 years ago

#1 @markjaquith
10 years ago

Just for ease of use, right? User-definable wp-content directory would be a bit more complicated.

#2 @Nazgul
10 years ago

  • Owner changed from anonymous to Nazgul

Indeed for ease of use and consistency.

(And it saves some effort if we do want to change the folder name in the future.)

#3 @Otto42
9 years ago

Would it make sense to have a WPADM as well?

#4 @foolswisdom
9 years ago

  • Milestone changed from 2.2 to 2.3

#5 @markjaquith
9 years ago

  • Keywords needs-patch added; has-patch removed
  • Milestone changed from 2.3 to 2.4 (next)

Patch needs a refresh. Punting.

@Nazgul
9 years ago

#6 @Nazgul
9 years ago

  • Keywords has-patch added; needs-patch removed
  • Status changed from new to assigned

Patch refreshed

#7 @markjaquith
9 years ago

  • Keywords needs-patch added; has-patch removed

Nazgul, rss.php:645 -- you can't use a constant here (nor a variable, nor a function -- only hardcoded values)

@Nazgul
9 years ago

#8 @Nazgul
9 years ago

  • Keywords has-patch added; needs-patch removed

I learn something new every day. :) re-refreshed patch added.

#9 @DD32
9 years ago

you can't use a constant here (nor a variable, nor a function -- only hardcoded values)

I guess thats because its a Default class variable?

If so, Nazgul, you should set the default base in the constructor rather than just hard coding it if your modifying them all.

@Nazgul
9 years ago

With DD32's constructor suggestion

#10 @darkdragon
9 years ago

This will break the enhancement to change the location of wp-content. There really should be a decision on whether to allow for those folders to be moved and make every place handle it well.

I would say that this ticket should be closed to allow for that change or at least not as drastic in some areas as to prevent the ability to relocate the wp-content folder.

#11 @darkdragon
8 years ago

  • Milestone changed from 2.5 to 2.6

#12 @Nazgul
8 years ago

  • Milestone 2.6 deleted
  • Resolution set to wontfix
  • Status changed from assigned to closed

Closing due to lack of traction.

Note: See TracTickets for help on using tickets.