WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#38450 closed defect (bug) (fixed)

Twenty Seventeen: Remove whitelisting comments for PHP_CodeSniffer

Reported by: davidakennedy's profile davidakennedy Owned by:
Milestone: 4.7 Priority: normal
Severity: normal Version: 4.7
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

A few comments to whitelist PHP_CodeSniffer errors are left from the theme's time on GitHub and integration with Travis testing. Those should be removed.

Attachments (1)

38450.1.patch​ (2.4 KB) - added by davidakennedy 8 years ago.
Remove whitelisting comments for PHP_CodeSniffer

Download all attachments as: .zip

Change History (5)

@davidakennedy
8 years ago

Remove whitelisting comments for PHP_CodeSniffer

#1 @davidakennedy
8 years ago

  • Keywords has-patch added

#2 @karmatosed
8 years ago

  • Resolution set to fixed
  • Status changed from new to closed

https://core.trac.wordpress.org/changeset/38872 fixes.

Last edited 8 years ago by karmatosed (previous) (diff)

#3 @netweb
8 years ago

  • Milestone changed from Awaiting Review to 4.7

This ticket was mentioned in ​Slack in #themereview by dingo_d. ​View the logs.
7 years ago

Note: See TracTickets for help on using tickets.