WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 16 months ago

#38468 closed enhancement (fixed)

Twenty Sixteen: Replace inline control structure in twentysixteen_content_image_sizes_attr()

Reported by: SergeyBiryukov Owned by: SergeyBiryukov
Milestone: 4.9 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: needs-refresh
Focuses: Cc:

Description

Background: #38384 for Twenty Seventeen.

See twentysixteen_content_image_sizes_attr().

To improve code readability, lines 374, 377, 379, and 380 should be changed to a proper if ( ) {} block.

Change History (9)

#1 follow-up: @ocean90
2 years ago

  • Keywords needs-patch good-first-bug removed
  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

Development of Twenty Sixteen happens on GitHub. This should be reported at https://github.com/WordPress/twentysixteen/issues.

#2 in reply to: ↑ 1 @SergeyBiryukov
2 years ago

Replying to ocean90:

Development of Twenty Sixteen happens on GitHub. This should be reported at https://github.com/WordPress/twentysixteen/issues.

Should we close #38338 and #38623 with the same reasoning?

It's counter-intuitive that all bundled themes (including Twenty Seventeen) are developed here, while Twenty Sixteen is developed elsewhere.

#3 @SergeyBiryukov
2 years ago

@davidakennedy Should I reopen the ticket or file it on GitHub? :)

This ticket was mentioned in Slack in #core-themes by sergey. View the logs.


22 months ago

#5 @SergeyBiryukov
20 months ago

  • Milestone set to Awaiting Review
  • Resolution invalid deleted
  • Status changed from closed to reopened

Reopening, as there's a consensus on merging Twenty Sixteen into core SVN in #36497.

#6 @SergeyBiryukov
17 months ago

  • Milestone changed from Awaiting Review to 4.9

#7 @SergeyBiryukov
17 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from reopened to closed

In 41343:

Twenty Sixteen: Replace inline control structureв to improve code readability.

Fixes #38468.

#8 @truongwp
16 months ago

  • Keywords needs-refresh added
  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Type changed from defect (bug) to enhancement

In this changeset: https://core.trac.wordpress.org/changeset/41343 I think should be a space before { in line 374 if ( 840 <= $width ){

#9 @SergeyBiryukov
16 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 41580:

Twenty Sixteen: After [41343], add missing space to if condition in twentysixteen_content_image_sizes_attr().

Fixes #38468.

Note: See TracTickets for help on using tickets.