Opened 10 years ago
Closed 9 years ago
#38468 closed enhancement (fixed)
Twenty Sixteen: Replace inline control structure in twentysixteen_content_image_sizes_attr()
| Reported by: | SergeyBiryukov | Owned by: | SergeyBiryukov |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.9 |
| Component: | Bundled Theme | Version: | |
| Severity: | normal | Keywords: | needs-refresh |
| Cc: | Focuses: |
Description
Background: #38384 for Twenty Seventeen.
See twentysixteen_content_image_sizes_attr().
To improve code readability, lines 374, 377, 379, and 380 should be changed to a proper if ( ) {} block.
Change History (9)
#1
follow-up:
↓ 2
@
10 years ago
- Keywords needs-patch good-first-bug removed
- Milestone Awaiting Review
- Resolution → invalid
- Status new → closed
#2
in reply to: ↑ 1
@
10 years ago
Replying to ocean90:
Development of Twenty Sixteen happens on GitHub. This should be reported at https://github.com/WordPress/twentysixteen/issues.
Should we close #38338 and #38623 with the same reasoning?
It's counter-intuitive that all bundled themes (including Twenty Seventeen) are developed here, while Twenty Sixteen is developed elsewhere.
This ticket was mentioned in Slack in #core-themes by sergey. View the logs.
9 years ago
#5
@
9 years ago
- Milestone → Awaiting Review
- Resolution invalid
- Status closed → reopened
Reopening, as there's a consensus on merging Twenty Sixteen into core SVN in #36497.
#8
@
9 years ago
- Keywords needs-refresh added
- Resolution fixed
- Status closed → reopened
- Type defect (bug) → enhancement
In this changeset: https://core.trac.wordpress.org/changeset/41343
I think should be a space before { in line 374 if ( 840 <= $width ){
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Development of Twenty Sixteen happens on GitHub. This should be reported at https://github.com/WordPress/twentysixteen/issues.