Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#38492 closed defect (bug) (fixed)

Customizer only previews the homepage

Reported by: welcher's profile welcher Owned by: westonruter's profile westonruter
Milestone: 4.7 Priority: normal
Severity: normal Version: 4.7
Component: Customize Keywords: has-patch commit
Focuses: Cc:

Description

When going into the customizer from any piece of content, the homepage is loaded and I am unable to navigate to other content.

I was running VIP Quickstart with Twenty Fifteen.

Attachments (2)

38492.0.diff (839 bytes) - added by westonruter 7 years ago.
38492.1.diff (860 bytes) - added by westonruter 7 years ago.

Download all attachments as: .zip

Change History (9)

#1 @celloexpressions
7 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 4.7
  • Summary changed from Customizer only shows the homepage to Customizer only previews the homepage

Confirmed on a clean install with Twenty Seventeen. Only the front page or posts page will be previewed, opening the customizer from another page or trying to navigate within the preview redirects back to the front page.

@westonruter
7 years ago

#2 @westonruter
7 years ago

  • Keywords has-patch added; needs-patch removed

@welcher see 38492.0.diff. There was a logic bug there were a couple variables were reversed. This is a regression introduced in [38890] for #38409

This ticket was mentioned in Slack in #core-customize by westonruter. View the logs.


7 years ago

@westonruter
7 years ago

#4 @celloexpressions
7 years ago

  • Keywords commit added

Looks good.

#5 @welcher
7 years ago

  • Keywords commit removed

@westonruter manually applied the fix on my local VIP Quickstart instance and the preview is correct.

#6 @welcher
7 years ago

  • Keywords commit added

#7 @westonruter
7 years ago

  • Owner set to westonruter
  • Resolution set to fixed
  • Status changed from new to closed

In 38926:

Customize: Fix logic inversion in determining whether a URL is previewable which prevented previewing anything but homepage.

Fixes regression introduced in [38890].

See #38409.
Fixes #38492.

Note: See TracTickets for help on using tickets.