Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#38496 closed defect (bug) (fixed)

Twenty Seventeen: Header too short on subpages

Reported by: laurelfulford's profile laurelfulford Owned by: davidakennedy's profile davidakennedy
Milestone: 4.7 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

When not on the front page, the header is not tall enough on page load to display both the site title and tagline:

https://cldup.com/l_ERqd0n8y.thumb.jpg

If you resize the browser window, it fixes the issue.

It looks like an issue with where setNavProps() is being fired on page load.

Attachments (1)

38496.patch (760 bytes) - added by laurelfulford 8 years ago.

Download all attachments as: .zip

Change History (5)

#1 @laurelfulford
8 years ago

  • Keywords needs-patch added

@laurelfulford
8 years ago

#2 @laurelfulford
8 years ago

  • Keywords has-patch added; needs-patch removed

In 38496.patch, I moved setNavProps so it's no longer only fired on load when the scroll down arrow is present.

#3 @davidakennedy
8 years ago

  • Milestone changed from Awaiting Review to 4.7

#4 @davidakennedy
8 years ago

  • Owner set to davidakennedy
  • Resolution set to fixed
  • Status changed from new to closed

In 38964:

Twenty Seventeen: Fix header height on sub-pages.

Moves setNavProps so it's no longer only fired on load when the scroll down arrow is present.

Props laurelfulford.

Fixes #38496.

Note: See TracTickets for help on using tickets.