WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#38497 closed enhancement (fixed)

Replace get_blog_details() in unit tests with get_site()

Reported by: flixos90 Owned by: jeremyfelt
Milestone: 4.7 Priority: normal
Severity: normal Version:
Component: Networks and Sites Keywords: has-patch
Focuses: multisite Cc:
PR Number:

Description

As part of #37102, all occurrences of get_blog_details() in unit tests should be replaced with get_site() as long as the respective tests do not handle functionality of get_blog_details() specifically.

Attachments (1)

38497.diff (11.0 KB) - added by flixos90 3 years ago.

Download all attachments as: .zip

Change History (3)

@flixos90
3 years ago

#1 @flixos90
3 years ago

  • Keywords has-patch added; needs-patch removed
  • Owner set to jeremyfelt
  • Status changed from new to reviewing

38497.diff replaces get_blog_details() with get_site() where applicable.

#2 @jeremyfelt
3 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 38935:

Multisite: Use get_site() in tests where get_blog_details() is not tested.

Remaining tests either rely on the blog-details cache key or test get_blog_details() itself.

Props flixos90.
Fixes #38497.

Note: See TracTickets for help on using tickets.