Twenty Seventeen: Unnecessary l10n variables

[enodekciw]

Hey,

Since [38909], both

if ( 'true' === twentyseventeenScreenReaderText.has_navigation )

conditionals in /twentyseventeen/assets/js/global.js can be changed to

if ( $menuScrollDown.length )

which would also allow $twentyseventeen_l10n['has_navigation'] to be completely removed from functions.php

[enodekciw]

Now that I had some time to catch up to recent code changes and dig deeper into this, seems that it might be a bit trickier to do this than I initially thought. Just changing the conditional doesn't make menu function as desired.

Decided to tinker with this tonight, attaching a patch. This is probably not the final version of the patch and will still need some tweaking, but might be something to work on.

Did some testing - works as intended (at least on my side).

Sorry, if I messed it up somehow - this is my first contribution using svn/trac.

P.S. I might not be able to update the patch myself, so feel free to take over.

[laurelfulford]

@enodekciw your patch looked really good to me!

In 38502.1.patch​ I made two very minor formatting tweaks (removed a line break and an empty space at the end of one line.

I also added a fix for a issue that was noticed while testing - when there is no custom header image, the scroll down arrow should not appear next to the navigation on the front page. It should only be there when there's a big header.

[davidakennedy]

In 39073:

Twenty Seventeen: Remove unnecessary l10n variables

• Relies on header skip link instead of l10n variables in JavaScript.
• Fixes issue where scroll down arrow appeared next to the navigation on the front page with no header image or video. It now only appears with a big header.

Props enodekciw, laurelfulford.

Fixes #38502.