![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 10 years ago
Last modified 15 months ago
#38507 new defect (bug)
Quick Edit: Parent label without input when editing page
| Reported by: | swissspidy | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | Future Release |
| Component: | Quick/Bulk Edit | Version: | |
| Severity: | normal | Keywords: | has-patch has-screenshots |
| Cc: | Focuses: |
Description
Noticed while working on #18375.
To reproduce:
- Delete all pages
- Create a new page, save as Draft
- Click Quick Edit or Bulk Edit
- Notice a 'Parent' label without any dropdown
It might make sense to always use 'show_option_none' in wp_dropdown_pages(), even when there are no pages. However, that might lead to data loss when a parent ID is set but the page does not exist anymore. Instead, the 'Parent' label could be hidden.
Screenshot:
Attachments (2)
Change History (7)
#1
@
10 years ago
- Keywords has-patch added; needs-patch has-screenshots removed
I added a patch that first sends the output of wp_dropdown_pages() into a variable and check to see if it is empty before outputting the label and dropdown.
#2
@
10 years ago
- Keywords has-screenshots added
- Milestone Awaiting Review → Future Release
38507.2.diff is a refreshed patch from the root directory (src) so that it applies cleanly, e.g. when using grunt patch.
Screenshot:
This ticket was mentioned in PR #9205 on WordPress/wordpress-develop by @sukhendu2002.
15 months ago
#5
- Keywords needs-refresh removed
Trac ticket: https://core.trac.wordpress.org/ticket/38507
Updated code to check if the dropdown is empty before outputting the variable and dropdown.