Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#38513 closed defect (bug) (fixed)

Twenty Seventeen: missing selective refresh for site title and tagline

Reported by: celloexpressions's profile celloexpressions Owned by: davidakennedy's profile davidakennedy
Milestone: 4.7 Priority: normal
Severity: normal Version: 4.5
Component: Bundled Theme Keywords: has-patch
Focuses: ui Cc:

Description

We should also add support for header images, but that'll need to wait for #38172. Patch likely conflicts with #38426, which should be committed first. Shouldn't be difficult to merge.

This is required to expose the visual edit icons exposed in #27403, see the corresponding forthcoming make/core post for details. Twenty Eleven through Sixteen added selective refresh for site title and tagline when it was reduced in WordPress 4.5. Patch is mostly copied from Twenty Fifteen.

@davidakennedy this should be in beta 1 if possible to coordinate with the forthcoming commit on #27403 this morning.

Attachments (1)

38513.diff (2.0 KB) - added by celloexpressions 8 years ago.
Add selective refresh to the site title and tagline, based on Twenty Fifteen.

Download all attachments as: .zip

Change History (2)

@celloexpressions
8 years ago

Add selective refresh to the site title and tagline, based on Twenty Fifteen.

#1 @davidakennedy
8 years ago

  • Owner set to davidakennedy
  • Resolution set to fixed
  • Status changed from new to closed

In 38966:

Twenty Seventeen: Implement selective refresh for site title and tagline

Adding the opacity property to the site title prevents opacity from changing during selective refreshes in the Customizer preview.

Props celloexpressions.

Fixes #38513.

Note: See TracTickets for help on using tickets.