WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#38515 closed defect (bug) (fixed)

Twenty Seventeen: ul inside ol is mistakenly ordered

Reported by: tg29359 Owned by: karmatosed
Milestone: 4.7 Priority: normal
Severity: normal Version: 4.7
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

for example, write the bellow

<ol>
<li>one</li>
<li>two</li>
<li>three
<ul>
<li>ul in the three A</li>
<li>ul in the three B</li>
<li>ul in the three C</li>
</ul>
</li>
<li>four</li>
<li>five</li>
</ol>

then it is displayed as the bellow.

1.one
2.two
3.three
  4.ul in the three A
  5.ul in the three B
  6.ul in the three C
7.four
8.five

see http://meta-scheme.jp/8081.

it should be displayed as the bellow.

1.one
2.two
3.three
  .ul in the three A
  .ul in the three B
  .ul in the three C
4.four
5.five

Attachments (3)

38515.patch (551 bytes) - added by Soean 5 years ago.
Resets the ol list style for nested ul
38515.2.patch (598 bytes) - added by davidakennedy 5 years ago.
Removes custom styles for ordered lists
38515.3.patch (999 bytes) - added by davidakennedy 5 years ago.
Updates to removes indents and add RTL styles.

Download all attachments as: .zip

Change History (9)

@Soean
5 years ago

Resets the ol list style for nested ul

#1 @Soean
5 years ago

  • Keywords has-patch added

#2 @karmatosed
5 years ago

  • Milestone changed from Awaiting Review to 4.7

@davidakennedy
5 years ago

Removes custom styles for ordered lists

#3 @davidakennedy
5 years ago

Thanks @tg29359 and @Soean!

After talking to @melchoyce and @laurelfulford, it seems like the custom implementation for ordered lists causes a lot of issues with mixed lists. See:

https://cloudup.com/clIe-QvYlYo

38515.2.patch fixes that and goes with more standard styles. It's easier to do that than account for all the edge cases.

@davidakennedy
5 years ago

Updates to removes indents and add RTL styles.

#4 @SergeyBiryukov
5 years ago

  • Summary changed from ul inside ol is mistakenly ordered with Twenty Seventeen to Twenty Seventeen: ul inside ol is mistakenly ordered

#5 @laurelfulford
5 years ago

Just tested 38515.3.patch; it fixes the issue and looks good!

#6 @karmatosed
5 years ago

  • Owner set to karmatosed
  • Resolution set to fixed
  • Status changed from new to closed

In 39079:

Twenty Seventeen: Fixes ul inside ol being wrongly ordered.

Now the listing displays correctly.

Props tg29359, Soean, laurelfulford, davidakennedy
Fixes #38515

Note: See TracTickets for help on using tickets.