WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#38519 closed defect (bug) (fixed)

Twenty Seventeen: Implement Placeholder Styles

Reported by: davidakennedy Owned by: karmatosed
Milestone: 4.7 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

Styles for placeholders were designed, but not implemented.

They should be:

color: #333;
font-family: "Libre Franklin", "Helvetica Neue", helvetica, arial, sans-serif;

See: https://github.com/WordPress/twentysixteen/blob/master/style.css#L558 for reference.

cc: @melchoyce.

Attachments (1)

38519.1.patch (1.8 KB) - added by davidakennedy 4 years ago.
Adds placeholder styles.

Download all attachments as: .zip

Change History (4)

@davidakennedy
4 years ago

Adds placeholder styles.

#1 @davidakennedy
4 years ago

  • Keywords has-patch added; needs-patch removed

From, 38519.1.patch:

Before:

https://cldup.com/fbis2OEHBW.png

After:

https://cldup.com/iL_gp86LLt.png

https://cldup.com/dVvGd_L3yG.png

#2 @melchoyce
4 years ago

Looks good to me.

#3 @karmatosed
4 years ago

  • Owner set to karmatosed
  • Resolution set to fixed
  • Status changed from new to closed

In 38969:

Twenty Seventeen: Placeholder styling

These were designed but never implemented.

Props melchoyce, davidakennedy
Fixes #38519

Note: See TracTickets for help on using tickets.