WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#38523 closed defect (bug) (fixed)

Customizer background UI erroneously presumes existence of controls and settings

Reported by: westonruter Owned by: westonruter
Milestone: 4.7 Priority: normal
Severity: normal Version:
Component: Customize Keywords: has-patch
Focuses: Cc:

Description

Follow-up on #22058 (Improve custom background properties UI) and changeset r38948.

The new background properties UI code assumes that the various controls and settings all exist for the various background properties. However, a theme may remove any of these controls. I noticed this in the Make theme, in which an error is raised when attempting to toggle the visibility of the background_attachment control.

Attachments (2)

error.png (427.8 KB) - added by westonruter 4 years ago.
38523.0.diff (1.7 KB) - added by westonruter 4 years ago.

Download all attachments as: .zip

Change History (4)

@westonruter
4 years ago

@westonruter
4 years ago

#1 @westonruter
4 years ago

  • Keywords has-patch added

#2 @westonruter
4 years ago

  • Owner set to westonruter
  • Resolution set to fixed
  • Status changed from new to closed

In 38977:

Customize: Check for existence of controls and settings for background properties before attempting to access.

Amends [38948].
See #22058.
Fixes #38523.

Note: See TracTickets for help on using tickets.