WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#38525 closed defect (bug) (fixed)

"Theme locations" / "Menu Locations" when editing a nav menu are confusing labels

Reported by: helen Owned by: helen
Milestone: 4.7 Priority: low
Severity: minor Version:
Component: Menus Keywords: good-first-bug has-patch
Focuses: docs Cc:

Description

First: the fact that there are two different labels (admin screen vs. customizer respectively) is pretty terrible. But beyond that, neither really makes a lot of sense in the context of being a setting for the nav menu you are currently editing. IMO it should be "Display location", as in "this is the display location (or locations) I want for this particular nav menu I am currently editing". I don't really want to do an awkward "Display location(s)" type of string - the checkboxes hopefully indicate that you can display the same menu in more than one place, but in practice as far as I've ever seen that's not particularly common.

Attachments (1)

38525.diff (2.6 KB) - added by Fencer04 3 years ago.
Updated menu editing locations to all use Display Location rather than either Menu Locations or Theme Locations.

Download all attachments as: .zip

Change History (18)

#1 @celloexpressions
3 years ago

I wonder if just "Locations" might work? Although that's probably too vague.

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


3 years ago

#3 @lukecavanagh
3 years ago

The two current flows end up being

Appearance > Menus > Edit Menus
Appearance > Menus > Manage Locations

Appearance > Customize > Menus
Appearance > Customize > Menus > Menu Locations

Would it make sense have them both set the same, so Menu Locations?

#4 @celloexpressions
3 years ago

Visible edit shortcuts bring users directly to the selector for a given location, within the locations section. We should consider potential impacts on that flow as well.

#5 @helen
3 years ago

Specifically talking about when you are editing an individual nav menu, where the setting applies to that individual menu. "Menu Locations" as a standalone concept is not the issue at hand.

http://s.hyhs.me/hxgD/image.png http://s.hyhs.me/hxMH/image.png

#6 follow-up: @lukecavanagh
3 years ago

@helen

Do more users edit menus via Appearance Menus or Appearance Customizer Menus?

Appearance > Menus > Edit Menus
Appearance > Customize > Menus

#7 in reply to: ↑ 6 @helen
3 years ago

Replying to lukecavanagh:

Do more users edit menus via Appearance Menus or Appearance Customizer Menus?

What is the goal of this question? .org installs do not currently have any method of usage or click data collection, so I'm not sure where you expect that stat to come from or what impact it has on this ticket.

#8 @lukecavanagh
3 years ago

@helen 

I guess my end goal is this ticket just related to the customizer for menu editor or improving the menu editor in appearance?

#9 @helen
3 years ago

I do not know how to be clearer. I am proposing changing two strings to one different string that makes more sense in its shared context. It affects both.

#10 @lukecavanagh
3 years ago

@helen 

No that was clear enough.

#11 @Fencer04
3 years ago

I think using Menu Locations in both areas makes the most sense. If that is a consensus I can work on a patch today.

#12 @helen
3 years ago

@Fencer04: My preference would be to rename those two settings to "Display Location", per the ticket description:

IMO it should be "Display location", as in "this is the display location (or locations) I want for this particular nav menu I am currently editing".

Open to arguments for/against, as always.

@Fencer04
3 years ago

Updated menu editing locations to all use Display Location rather than either Menu Locations or Theme Locations.

#13 @Fencer04
3 years ago

  • Keywords has-patch added; needs-patch removed

I added a patch that changes the text to Display Locations so people can check that verbiage out. One question I had was whether or not we should change the variable name. It is currently $menu_locations. I haven't touched it since it's working but didn't know what the normal protocol is.

This ticket was mentioned in Slack in #core by helen. View the logs.


3 years ago

#16 @helen
3 years ago

I don't want this to keep lingering so I will massage the patch and commit - however, I want to note that what I was looking for here was only changing the setting label while editing an individual nav menu. "Menu Locations" is still a perfectly good term for the locations themselves, as referenced in other places.

#17 @helen
3 years ago

  • Owner set to helen
  • Resolution set to fixed
  • Status changed from new to closed

In 39098:

Menus: Use a label of "Display location" for individual nav menu settings.

While "Menu/Theme locations" was descriptive of what the choices listed were, in the context of editing an individual nav menu it is more descriptive to use a setting label that tells you what it is you are affecting for that nav menu, which is where it will be displayed. Technically multiple locations can be chosen, but in practice that appears to be rare enough that we can avoid an awkward "location(s)" type string.

props Fencer04 for the initial patch.
fixes #38525.

Note: See TracTickets for help on using tickets.