WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#38534 closed defect (bug) (fixed)

Twenty Seventeen: Sticky icon appearing in regular post flow

Reported by: laurelfulford's profile laurelfulford Owned by: karmatosed's profile karmatosed
Milestone: 4.7 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

The sticky icon is appearing with posts in regular flow, not just when they're stuck. Here it is on page 7:

https://cldup.com/mvdij6Hh-Q.thumb.jpg

This appears to be a regression; the same issue was fixed when the theme was on GitHub:

​https://github.com/WordPress/twentyseventeen/pull/349

Attachments (2)

38534.diff​ (367 bytes) - added by mangeshp 9 years ago.
.icon class was overriding the display:none of .icon-pinned class
38534.2.patch​ (389 bytes) - added by davidakennedy 9 years ago.
Targets posts that are not sticky to make sure SVG markup is hidden.

Download all attachments as: .zip

Change History (7)

#1 @laurelfulford
9 years ago

  • Keywords needs-patch added

#2 @davidakennedy
9 years ago

  • Milestone changed from Awaiting Review to 4.7

@mangeshp
9 years ago

.icon class was overriding the display:none of .icon-pinned class

#3 @mangeshp
9 years ago

  • Keywords has-patch added; needs-patch removed

@davidakennedy
9 years ago

Targets posts that are not sticky to make sure SVG markup is hidden.

#4 @laurelfulford
9 years ago

Tested 38534.2.patch​ and it looks good!

(38534.diff​ was on the right path, but the sticky icon class name changed, so it doesn't fix the issue at the moment).

#5 @karmatosed
9 years ago

  • Owner set to karmatosed
  • Resolution set to fixed
  • Status changed from new to closed

In 39080:

Twenty Seventeen: Sticky icon fix to stop appearing in regular post flow

The sticky icon was appearing in posts it shouldn't have, not just when stuck. This fixes that.

Props laurelfulford, mageshp, davidakennedy
Fixes #38534

Note: See TracTickets for help on using tickets.