Opened 8 years ago
Closed 8 years ago
#38538 closed defect (bug) (fixed)
Twenty Seventeen: Update page column setting
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.7 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-patch |
Focuses: | Cc: |
Description
Right now the page column setting is hidden when you have widgets in the Sidebar widget area. Since pages don't ever display the Sidebar widget area, the setting shouldn't be effected by it.
The description should be updated to:
You can opt to display all pages with a one column or two column layout. When the two column layout is assigned, the page title is in one column and content is in the other.
That does leave the question of archive pages. I think that if you don’t have widgets in the Sidebar widget area, the columns setting should probably also apply to archives — but if you do have widgets in the Sidebar widget area, the setting should be ignored on archive pages.
Attachments (2)
Change History (6)
#2
@
8 years ago
- Owner changed from celloexpressions to laurelfulford
38538.0.diff covers the customizer; archives need updates in the CSS to allow for a one-column option. I'm going to leave that part for @laurelfulford since I'm less familiar with that.
I ended up taking the pages part out of the description as well, as it's not really accurate. We may need to continue iterating here.
#3
@
8 years ago
- Keywords has-patch added
In 38538.1.diff I added some styles to make sure the archives also apply the one column layout when that option is selected and there are no sidebar widgets assigned.
First pass for customizer.