WordPress.org

Make WordPress Core

Opened 9 months ago

Closed 9 months ago

#38542 closed defect (bug) (fixed)

Twenty Seventeen: Missing theme text domain

Reported by: anilbasnet Owned by: davidakennedy
Milestone: 4.7 Priority: normal
Severity: normal Version: 4.7
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

Hardcoded string Top and Social should have text domain.
Now it is __( 'Top' )

Attachments (1)

38542.diff (679 bytes) - added by anilbasnet 9 months ago.

Download all attachments as: .zip

Change History (6)

@anilbasnet
9 months ago

#1 @anilbasnet
9 months ago

  • Keywords has-patch added

Patch added.

#2 @swissspidy
9 months ago

  • Milestone changed from Awaiting Review to 4.7

#3 @davidakennedy
9 months ago

Somewhat related feedback from @afercia regarding the menu label:

Hello. Minor thing, let me know if you want I open a ticket for this. I'd consider to give a more meaningful name to the "Top" menu location. "Top Menu" would be enough I guess, also consistent with "Social Links Menu"

See: https://wordpress.slack.com/archives/core-themes/p1477639232004365

I think this can be addressed here as well.

This ticket was mentioned in Slack in #core-themes by davidakennedy. View the logs.


9 months ago

#5 @davidakennedy
9 months ago

  • Owner set to davidakennedy
  • Resolution set to fixed
  • Status changed from new to closed

In 39001:

Twenty Seventeen: Adds missing theme text domains to starter content

  • Also, changes the top menu label so it has better context when read alone by assistive technology.

Props anilbasnet.

Fixes #38542.

Note: See TracTickets for help on using tickets.