REST-API Json decode error will not give back an error

[danielhuesken]

If you send a Request to the Rest API with a defect json in body than it will not return a error. That is not so good, because you get back a response that suggest all is ok.

Method: POST

The problem is located at: https://core.trac.wordpress.org/browser/trunk/src/wp-includes/rest-api/class-wp-rest-request.php#L673

The 'return;' let it looks like all is ok and the answere will be the normel responce.

[joehoyle]

Thanks @danielhuesken for the report! This seems legitimate to me. Throwing an error would help a lot for API clients that send malformed JSON - however we'll (maybe) want to make sure that if you send _both_ (I don't even know if that's possible) that we don't have a BC issue.

[danielhuesken]

Can it be a solution, to set a header with error codes/message? That you have a hint about the problem.

[rmccue]

Check for JSON encoding errors in has_valid_params

[joehoyle]

In 39109:

REST API: Return error when JSON decoding fails.

If you send a request to the REST API with invalid JSON in body than it will now return a error. This assists developers if they accidentally send invalid JSON and wonder why their data appears to be ignored.

Props rmccue.
Fixes #38547.

[rmccue]

In 39111:

REST API: Only provide JSON error code on PHP 5.3+.

json_last_error() was only added to PHP 5.3.0, so we can't provide the information for older versions.

See #38547.