WordPress.org

Make WordPress Core

Opened 8 months ago

Closed 8 months ago

Last modified 6 months ago

#38551 closed defect (bug) (fixed)

Twenty Seventeen is not installed with WordPress updates.

Reported by: nerrad Owned by:
Milestone: 4.7 Priority: highest omg bbq
Severity: normal Version: 4.7
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description (last modified by ocean90)

Readers of the [Beta 1 post](https://wordpress.org/news/) excited to try out the theme will be disappointed when updating using the beta tester plugin because the theme is not bundled.

This is due to work in #34306 (r35738).

The only way currently to install the latest twenty seventeen theme is to have this in one's wp-config.php file.

define( 'CORE_UPGRADE_SKIP_NEW_BUNDLED', false );

Attachments (2)

38551.patch (583 bytes) - added by ocean90 8 months ago.
38551.1.patch (1.2 KB) - added by ocean90 8 months ago.

Download all attachments as: .zip

Change History (16)

#1 @melchoyce
8 months ago

  • Milestone changed from Awaiting Review to 4.7

#2 @nerrad
8 months ago

Typo in commit reference. Should be r35738

This ticket was mentioned in Slack in #core by ocean90. View the logs.


8 months ago

#4 @ocean90
8 months ago

  • Component changed from Themes to Bundled Theme
  • Description modified (diff)
  • Keywords needs-patch added
  • Priority changed from normal to highest omg bbq

@ocean90
8 months ago

@ocean90
8 months ago

#5 @ocean90
8 months ago

38551.patch is probably a temporary solution. 38551.1.patch moves the block into update_core() to make use of the $development_build variable. This still needs a way to skip Twenty Sixteen since it could be a git checkout.

To test the patches you can use my custom packages:

<?php
add_filter( 'upgrader_pre_download', 'ds_switch_nightly_package', 10, 3 );
function ds_switch_nightly_package( $return, $package, $upgrader ) {
        if ( 'https://wordpress.org/nightly-builds/wordpress-latest.zip' !== $package ) {
                return $return;
        }

        // wordpress.zip for 38551.patch, wordpress2.zip for 38551.1.patch.
        $package = 'https://labs.dominikschilling.de/wp/wordpress2.zip';

        $upgrader->skin->feedback( 'downloading_package', $package );

        $download_file = download_url( $package );

        if ( is_wp_error( $download_file ) ) {
                return new WP_Error('download_failed', $upgrader->strings['download_failed'], $download_file->get_error_message() );
        }

        return $download_file;
}

#6 @davidakennedy
8 months ago

  • Keywords has-patch added; needs-patch removed

#7 @dd32
8 months ago

In 39064:

Upgrade: Install new themes upon upgrade again.
This partially reverts [35738], which has shown to provide a bad user experience for users seeking to experiment with TwentySeventeen.

This will result in TwentySixteen being installed in addition to TwentySeventeen.

See #38551.

#8 @dd32
8 months ago

In 39065:

Themes: Update the unit tests to handle [39064] and #31550.

test_default_theme_in_default_theme_list() was always being skipped after #31550, this causes it to once again check that the unit tests are up to date and include the latest default theme.
test_default_themes_have_textdomain() didn't play happy when a default theme wasn't installed on a site.

See #31550, #29925, #38551.

#9 @dd32
8 months ago

This will result in TwentySixteen being installed in addition to TwentySeventeen.

Turns out that's incorrect, we've fixed that issue.

I keep looking at [39064] and thinking i've missed something, but from what I can see, all the checks within the upgrader seem to take into account CORE_UPGRADE_SKIP_NEW_BUNDLED properly and TwentySixteen won't get re-installed (unless they're updating from pre-4.4).

I expect this is now fixed, I've refreshed the nightly build, if someone updating to the beta via the beta tester OR hitting update on the beta to the nightly should deliver the TwentySeventeen theme to the site.

#10 @johnpgreen
8 months ago

I'm running the Beta Testing plugin set to Bleeding Edge Nightlies on my localhost and had Twentyfourteen, Twentyfifteen, and Twentysixteen installed.

After updating to 39065 today, I had Twentyseventeen (expected) but also gained Twentyten, Twentyeleven, Twentytwelve, and Twentythirteen. I'm thinking the latter might not have been the original intention.

#11 @helen
8 months ago

Wanted to check on this point as well - will betas/nightlies get updates for Twenty Seventeen, as before?

#12 @ocean90
8 months ago

  • Resolution set to fixed
  • Status changed from new to closed

This ticket was mentioned in Slack in #core by ocean90. View the logs.


8 months ago

#14 @dd32
6 months ago

In 39687:

Upgrade: Fix the installation of TwentySeventeen upon upgrade from an early version.

This reverts part of [31124] which incorrectly caused $old_wp_version to equal the version of WordPress being upgraded to due to global variable access changes.

See #38551, #30799.
Fixes #39138 for trunk.

Note: See TracTickets for help on using tickets.