WordPress.org

Make WordPress Core

Opened 8 months ago

Closed 5 months ago

Last modified 3 weeks ago

#38562 closed enhancement (fixed)

Move "Site Language" setting above "Timezone"

Reported by: johnjamesjacoby Owned by: SergeyBiryukov
Milestone: 4.8 Priority: normal
Severity: normal Version:
Component: I18N Keywords: 2nd-opinion has-screenshots has-patch
Focuses: administration Cc:

Description

The "Site Language" setting is currently last in the "General Settings" page. It's also underneath do_settings_fields('general', 'default') which pretty much guarantees it will be last, even after plugins that insert settings having nothing to do with site locale.

I think it's more important than that, especially to non-English speakers that need this setting, to both prioritize it, and keep it snugged up against the other locale specific site settings.

To my eyes, it makes the most sense to move this above "Timezone" so the language can be set as early as possible. An argument against this is that it's not something that changes frequently (and the site owner theoretically had the chance to set this during site creation) so putting it higher up may seem odd, but having it below who-knows-what plugins might do also seems not ideal.

Screenshots and a recommended patch imminent.

Attachments (3)

38562.diff (3.3 KB) - added by johnjamesjacoby 8 months ago.
Move site language setting above "Timezone"
after.jpg (226.4 KB) - added by johnjamesjacoby 8 months ago.
After
before.jpg (190.2 KB) - added by johnjamesjacoby 8 months ago.
Before

Download all attachments as: .zip

Change History (13)

@johnjamesjacoby
8 months ago

Move site language setting above "Timezone"

@johnjamesjacoby
8 months ago

After

@johnjamesjacoby
8 months ago

Before

#1 @ChantalC
8 months ago

Agree. Makes more sense.

#2 @Presskopp
8 months ago

Yes, please.

#3 @swissspidy
7 months ago

  • Milestone changed from Awaiting Review to Future Release

This ticket was mentioned in Slack in #core-i18n by jjj. View the logs.


7 months ago

This ticket was mentioned in Slack in #core-multisite by jeremyfelt. View the logs.


6 months ago

#7 @SergeyBiryukov
5 months ago

  • Milestone changed from Future Release to 4.8

#8 @SergeyBiryukov
5 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 39885:

I18N: Move "Site Language" setting above "Timezone".

This brings all locale-specific site settings closer together and prevents the language setting from being pushed down by unrelated settings added by plugins.

Props johnjamesjacoby.
Fixes #38562.

#9 @johnjamesjacoby
5 months ago

Alright! Thanks everyone!

#10 @afercia
3 weeks ago

Related (for history): the missing spinner: #40478

Note: See TracTickets for help on using tickets.