Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 9 years ago

#38562 closed enhancement (fixed)

Move "Site Language" setting above "Timezone"

Reported by: johnjamesjacoby Owned by: SergeyBiryukov
Priority: normal Milestone: 4.8
Component: I18N Version:
Severity: normal Keywords: 2nd-opinion has-screenshots has-patch
Cc: Focuses: administration

Description

The "Site Language" setting is currently last in the "General Settings" page. It's also underneath do_settings_fields('general', 'default') which pretty much guarantees it will be last, even after plugins that insert settings having nothing to do with site locale.

I think it's more important than that, especially to non-English speakers that need this setting, to both prioritize it, and keep it snugged up against the other locale specific site settings.

To my eyes, it makes the most sense to move this above "Timezone" so the language can be set as early as possible. An argument against this is that it's not something that changes frequently (and the site owner theoretically had the chance to set this during site creation) so putting it higher up may seem odd, but having it below who-knows-what plugins might do also seems not ideal.

Screenshots and a recommended patch imminent.

Attachments (3)

38562.diff​ (3.3 KB ) - added by johnjamesjacoby 10 years ago.
Move site language setting above "Timezone"
after.jpg​ (226.4 KB ) - added by johnjamesjacoby 10 years ago.
After
before.jpg​ (190.2 KB ) - added by johnjamesjacoby 10 years ago.
Before

Download all attachments as: .zip

Change History (13)

@johnjamesjacoby
10 years ago

Move site language setting above "Timezone"

@johnjamesjacoby
10 years ago

After

@johnjamesjacoby
10 years ago

Before

#1 @ChantalC
10 years ago

Agree. Makes more sense.

#2 @Presskopp
10 years ago

Yes, please.

#3 @swissspidy
10 years ago

  • Milestone Awaiting Review → Future Release

This ticket was mentioned in ​Slack in #core-i18n by jjj. ​View the logs.


10 years ago

This ticket was mentioned in ​Slack in #core-multisite by jeremyfelt. ​View the logs.


10 years ago

#7 @SergeyBiryukov
10 years ago

  • Milestone Future Release → 4.8

#8 @SergeyBiryukov
10 years ago

  • Owner set to SergeyBiryukov
  • Resolution → fixed
  • Status new → closed

In 39885:

I18N: Move "Site Language" setting above "Timezone".

This brings all locale-specific site settings closer together and prevents the language setting from being pushed down by unrelated settings added by plugins.

Props johnjamesjacoby.
Fixes #38562.

#9 @johnjamesjacoby
10 years ago

Alright! Thanks everyone!

#10 @afercia
9 years ago

Related (for history): the missing spinner: #40478

Note: See TracTickets for help on using tickets.