Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#38567 closed defect (bug) (fixed)

Twenty Seventeen: Unify labels for front page sections

Reported by: clorith's profile Clorith Owned by: karmatosed's profile karmatosed
Milestone: 4.7 Priority: normal
Severity: normal Version: 4.7
Component: Bundled Theme Keywords: has-patch ui-feedback
Focuses: ui Cc:

Description

As reported by @ahortin in Alpha/Beta.

The Front page section # Content are labeled as such in the customizer Theme Options, but the preview calls them Panel # placeholder.

These should ideally have the same label to avoid any confusion, most likely the appropriate approach would be to re-label the preview ones to Front page section # placeholder, as this removed any confusion as to where the panels might come into play (and might be easier to translate I would imagine?).

Attachments (1)

38567.1.patch (962 bytes) - added by davidakennedy 7 years ago.
Changes panel placeholder language to be consistent with Customizer.

Download all attachments as: .zip

Change History (5)

#1 @celloexpressions
7 years ago

  • Focuses ui added
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 4.7

All of the code uses panel, but it looks like the customizer labels are all section. Section makes more sense to me, but if we have specific reasoning one way or another we can decide which way to go. Or, we could run both through some user tests. I'm also not convinced that either word is the right terminology to describe this.

#2 @ahortin
7 years ago

I think section works ok. My main concern was that I believe both the customizer lablels and the live priview labels should be the same, so as to avoid any confusion. So don't even use the word placeholder. If the customizer label is Front Page Section 1 Content then the live preview label should also be Front Page Section 1 Content so that users can clearly see that the customizer option and that particular section in the live preview are related.

Version 0, edited 7 years ago by ahortin (next)

@davidakennedy
7 years ago

Changes panel placeholder language to be consistent with Customizer.

#3 @davidakennedy
7 years ago

  • Keywords has-patch ui-feedback added; needs-patch removed

I agree that using the same language here would help. 38567.1.patch does that.

#4 @karmatosed
7 years ago

  • Owner set to karmatosed
  • Resolution set to fixed
  • Status changed from new to closed

In 39094:

Twenty Seventeen: Unifies the labels for front page sections

Front page sesctions # Content were labelled in Customizer Theme Options but the preview called it Panel # placeholder. This unifies that.

Props Clorith, ahortin, celloexpressions, davidakennedy
Fixes #38567

Note: See TracTickets for help on using tickets.