Opened 8 years ago
Closed 8 years ago
#38567 closed defect (bug) (fixed)
Twenty Seventeen: Unify labels for front page sections
Reported by: | Clorith | Owned by: | karmatosed |
---|---|---|---|
Milestone: | 4.7 | Priority: | normal |
Severity: | normal | Version: | 4.7 |
Component: | Bundled Theme | Keywords: | has-patch ui-feedback |
Focuses: | ui | Cc: |
Description
As reported by @ahortin in Alpha/Beta.
The Front page section # Content
are labeled as such in the customizer Theme Options, but the preview calls them Panel # placeholder
.
These should ideally have the same label to avoid any confusion, most likely the appropriate approach would be to re-label the preview ones to Front page section # placeholder
, as this removed any confusion as to where the panels might come into play (and might be easier to translate I would imagine?).
Attachments (1)
Change History (5)
#1
@
8 years ago
- Focuses ui added
- Keywords needs-patch added
- Milestone changed from Awaiting Review to 4.7
#2
@
8 years ago
I think section
works ok. My main concern was that I believe both the customizer lablels and the live priview labels should be the same, so as to avoid any confusion. So don't even use the word placeholder
. If the customizer label is Front Page Section 1 Content
then the live preview label should also be Front Page Section 1 Content
so that users can clearly see that the customizer option and that particular section in the live preview are related.
#3
@
8 years ago
- Keywords has-patch ui-feedback added; needs-patch removed
I agree that using the same language here would help. 38567.1.patch does that.
All of the code uses
panel
, but it looks like the customizer labels are allsection
. Section makes more sense to me, but if we have specific reasoning one way or another we can decide which way to go. Or, we could run both through some user tests. I'm also not convinced that either word is the right terminology to describe this.