WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 3 years ago

#38600 closed enhancement (fixed)

Twenty Seventeen: Rename Menu Location "Top" in the Menu Settings

Reported by: transl8or Owned by:
Milestone: 4.7 Priority: normal
Severity: normal Version: 4.7
Component: Menus Keywords:
Focuses: ui, administration Cc:

Description

I would suggest to rename the theme location "Top" to "Primary Menu" or "Top primary menu" (like in Twenty Fourteen) in the Menu Settings.

Change History (7)

#1 @karmatosed
5 years ago

Hi @transl8or, thanks for your suggestion. Unfortunately, I disagree we should do this. It's worth noting that we shouldn't just do something because in past we did, this is one of those cases. 'Primary' isn't a great additional word as it may not be that for people. 'Top' says the position and is a lot more meaningful as a result for users.

For example, if I want to add a menu, I know if it's called 'Top' that it indeed displays there. 'Primary' leaves me not knowing where it is positioned and guessing.

I would as a result, be against a change that adds the word 'Primary'. If the word top is there it's not needed and if the word 'Primary' is added, again it's not needed as we have the more meaningful 'Top'.

#2 @karmatosed
5 years ago

  • Type changed from defect (bug) to enhancement

#3 @transl8or
5 years ago

Hi @karmatosed, I really understand you with that.

I just thought quite a bit about it. And just to explain:
It totally makes sense that the menu is called 'top' in the predefined content of Twenty Seventeen.
But I was struggling with the second "Top" in the Menu Settings (which was usually "Primary Menu" oder "Top Primary Menu" or "Secondary Menu" or "_whatever_a_themer_chooses" in other (default) Themes).
Of course we dont need that to change, just because it was always the way or because of consistency. True.

But while translating the theme - and please dont forget I am not an english native speaker - I was thinking about a better word there beneath and under "Theme locations" and "Manage locations" in the Menu settings.

Maybe "On top" or "At top" would be better and be appropriate there too, and makes a better connection to the word "location".

And the second, for the custom user description in the default delivered content stays of course "top".

I mean that bc the theme allows, like most others, adding another menu over widgets.

#4 @karmatosed
5 years ago

Thanks for more context. I still feel that top says what it does and find it hard seeing how primary does change that. I'd still say we keep as is. I have a feeling there could be an argument to add 'menu' to it but it's obviously a menu. Primary doesn't help as it may not be primary.

Last edited 5 years ago by karmatosed (previous) (diff)

#5 @davidakennedy
5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Hi @transl8or! Thanks for the ticket!

This was changed recently, thanks to similar feedback concerning accessibility. See:

https://core.trac.wordpress.org/changeset/39001/trunk/src/wp-content/themes/twentyseventeen

Closing this out.

#6 @netweb
5 years ago

  • Milestone Awaiting Review deleted

#7 @SergeyBiryukov
3 years ago

  • Milestone set to 4.7
Note: See TracTickets for help on using tickets.