WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 9 years ago

#38611 closed enhancement (fixed)

Clarify why get_post_format_slugs() calls array_combine()

Reported by: danielbachhuber Owned by: DrewAPicture
Priority: normal Milestone: 4.9
Component: Post Formats Version:
Severity: normal Keywords: has-patch
Cc: Focuses: docs

Description

Discovered from #38610

Attachments (1)

38611.1.diff​ (488 bytes ) - added by danielbachhuber 10 years ago.

Download all attachments as: .zip

Change History (6)

#1 @danielbachhuber
10 years ago

  • Focuses docs added
  • Keywords has-patch added; needs-patch removed
  • Type defect (bug) → enhancement

Actually, ​maybe not unnecessarily:

I don't think I wrote this but I did review it. Gives you an array of slugs with the slugs as keys. Helpful! (at the time)

@danielbachhuber
10 years ago

#2 @danielbachhuber
10 years ago

  • Summary get_post_format_slugs() unnecessarily calls array_combine() → Clarify why get_post_format_slugs() calls array_combine()

#4 @DrewAPicture
9 years ago

  • Milestone Awaiting Review → 4.9

#5 @DrewAPicture
9 years ago

  • Owner set to DrewAPicture
  • Resolution → fixed
  • Status new → closed

In 41284:

Docs: Improve the return description for get_post_format_slugs() to note that the array contains slugs as both keys and values.

Props danielbachhuber.
Fixes #38611.

Note: See TracTickets for help on using tickets.