Show toolbar (admin bar) in the user's locale (language)

[swissspidy]

After #29783 and #26511 it might make sense to show the toolbar on the front-end in the user's locale, while keeping the rest of the site in the site's locale.

#29783 actually has a proof-of-concept for that. Screenshot: ​https://twitter.com/swissspidy/status/773571032963751936

[swissspidy]

38643.diff​ should do the trick. Post type labels need to be fixed first though. See discussion at #26511 for this.

[swissspidy]

#39068 was marked as a duplicate.

[swissspidy]

#38218 is a possible solution for the post type labels.

[swissspidy]

This relies on #41305 being fixed first.

[SergeyBiryukov]

#46759 was marked as a duplicate.

[sabernhardt]

#51654 was marked as a duplicate.

[SergeyBiryukov]

#53442 was marked as a duplicate.

[sabernhardt]

I refreshed the previous patch against trunk, and it still needs some work.

Of course, it does not include the lazily evaluated translations (#41305).

Also, the toolbar container should have a lang attribute when the profile language does not match the page (whether that is in the site default or a third language).

[ocean90]

#53794 was marked as a duplicate.

[johnbillion]

#60627 was marked as a duplicate.

[oglekler]

I am changing the Summary to make it easier to find this ticket. I believe that this is called Admin bar, so I didn't search for a toolbar

Updated the admin bar styles in WordPress, adding a function to automatically set the text direction based on the user's locale. This helps ensure correct rendering of the admin bar for right-to-left languages. The function also restores the previous locale after rendering the admin bar.

[pbearne]

refreshed

not sure how to test this :-)

The issue with post type labels being in the wrong locale is still unsolved

[sabernhardt]

Thanks for moving this ticket forward, but it likely will not be ready for 6.7.

[pbearne]

Replying to swissspidy:

I tried to look at this but could see the issue with the post labels

Can you provide an image of the faulty text?

[swissspidy]

It's not a "faulty text". The fundamental problem is that post types are registered in the current locale and then the labels are just translated into the current locale. Switching locales does not have any effect anymore. So even if you show the toolbar in the user's locale (which we had a patch for for 8+ years), the post type labels will always be incorrect, which is very confusing.

There are long prior discussions at #26511 and #38218.

#41305 is probably the only way to truly solve this, which is also mentioned in an earlier comment above. But that has significant drawbacks around backward compatibility.

[pbearne]

Replying to swissspidy:

It's not a "faulty text". The fundamental problem is that post types are registered in the current locale and then the labels are just translated into the current locale. Switching locales does not have any effect anymore. So even if you show the toolbar in the user's locale (which we had a patch for for 8+ years), the post type labels will always be incorrect, which is very confusing.

There are long prior discussions at #26511 and #38218.

#41305 is probably the only way to truly solve this, which is also mentioned in an earlier comment above. But that has significant drawbacks around backward compatibility.

I feel this patch is the best we can do for now and a good step in the right direction.
Can we get this added?

[swissspidy]

A half-baked solution in this case is arguably worse than just having everything in the same locale. Otherwise we would have probably done it already

[sabernhardt]

#65333 was marked as a duplicate.