WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#38648 closed defect (bug) (fixed)

No-op edit_post_link() when in a customizer preview

Reported by: helen Owned by: westonruter
Priority: normal Milestone: 4.7
Component: Customize Version:
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

I saw a comment about how the combination of shift-click hint + visible edit shortcuts + disabled cursor over inaccessible links was confusing, and I tend to agree. It's also silly to have edit links that don't work and don't represent a preview except for privileged logged-in users, so I say we no-op them (in a way that can be undone by devs who actually have a use for them in the preview pane).

Related: #27403, #30937

Attachments (1)

38648.0.diff​ (642 bytes ) - added by westonruter 10 years ago.

Download all attachments as: .zip

Change History (3)

@westonruter
10 years ago

#1 @westonruter
10 years ago

  • Keywords has-patch added
  • Owner set to westonruter
  • Status new → accepted

#2 @westonruter
10 years ago

  • Resolution → fixed
  • Status accepted → closed

In 39133:

Customize: No-op edit_post_link() when in customizer preview.

Edit links can be restored in plugins by removing the __return_empty_string function from the get_edit_post_link filter at the customize_preview_init action.

Fixes #38648.

Note: See TracTickets for help on using tickets.