Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#38654 closed defect (bug) (invalid)

The supportsVideo() method in the custom header script should be overridable

Reported by: bradyvercher Owned by:
Priority: normal Milestone:
Component: Themes Version: 4.7
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

The original intention for the supportsVideo() method in wp-custom-header.js was to define some sensible checks to determine when a header video should be embedded, but allow the method to be overridden by themes or plugins if necessary. However, that's not currently possible since the method is private.

Attachments (1)

38654.diff​ (2.8 KB ) - added by bradyvercher 10 years ago.

Download all attachments as: .zip

Change History (5)

@bradyvercher
10 years ago

#1 @bradyvercher
10 years ago

  • Keywords has-patch added

38654.diff​ refactors the pattern for the customer header module to make the supportsVideo() method public and overridable.

This ticket was mentioned in ​Slack in #core-themes by bradyvercher. ​View the logs.


10 years ago

#3 @bradyvercher
10 years ago

  • Resolution → invalid
  • Status new → closed

This was fixed in #38678

#4 @netweb
10 years ago

  • Milestone Awaiting Review
Note: See TracTickets for help on using tickets.