WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#38668 closed defect (bug) (fixed)

"Toggle edit shortcuts" is visible if theme has no styles for `.screen-reader-text` class

Reported by: ocean90 Owned by: westonruter
Milestone: 4.7 Priority: normal
Severity: normal Version: 4.7
Component: Customize Keywords: has-patch
Focuses: accessibility Cc:

Description

See screenshot from Twenty Twelve.

Attachments (4)

38668.png (61.8 KB) - added by ocean90 4 years ago.
38668.0.diff (2.8 KB) - added by westonruter 4 years ago.
Deprecate WP_Customize_Manager::customize_preview_loading_style(), moving styles to customize-preview.css. Add screen-reader-text rule.
38668.1.diff (1.2 KB) - added by westonruter 4 years ago.
38668.2.diff (1.9 KB) - added by westonruter 4 years ago.

Download all attachments as: .zip

Change History (8)

@ocean90
4 years ago

#1 @westonruter
4 years ago

@ocean90 Probably would be a good idea to include this in customize-preview.css, yes?

@westonruter
4 years ago

Deprecate WP_Customize_Manager::customize_preview_loading_style(), moving styles to customize-preview.css. Add screen-reader-text rule.

@westonruter
4 years ago

#2 @westonruter
4 years ago

  • Keywords has-patch added; needs-patch removed
  • Owner set to westonruter
  • Status changed from new to accepted

Actually, the toggle should have been removed entirely as part of [39131] since the edit shortcuts are now persistent when the controls are expanded.

#3 @sirbrillig
4 years ago

There's also the translation for that button:

src/wp-includes/customize/class-wp-customize-selective-refresh.php
191:                            'editShortcutVisibilityToggle'  => __( 'Toggle edit shortcuts' ),

@westonruter
4 years ago

#4 @westonruter
4 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 39144:

Customize: Remove edit shortcut toggle button from preview since visibility is now linked with pane visibility.

Amends [39131].
Props westonruter, sirbrillig.
See #27403.
Fixes #38668.

Note: See TracTickets for help on using tickets.