Standardize "found in trash" messages

[Presskopp]

Currently, we use the following strings, if trash is empty:

No pages found in Trash. (wp-includes/post.php:1375)
No posts found in Trash. (wp-includes/post.php:1375)
No media files found. (wp-includes/media.php:3451)
No comments found. (wp-admin/includes/class-wp-comments-list-table.php:189)

There's also a new string coming with 4.7:
No changesets found in Trash. (wp-includes/post.php:167)

We should either strip the "in Trash" part or add it to the ones where it's missing.

related: #38341 (there's a screenshot)

[ocean90]

"No media files found." and "No comments found." are also used when there are no items yet or a search result is empty.

[Presskopp]

What do you think of an approach like this (example: class-wp-comments-list-table.php)?

        public function no_items() {
                global $comment_status;

                if ( 'moderated' === $comment_status ) {
                        _e( 'No comments awaiting moderation.' );
                } else { 
                        if ( 'trash' === $comment_status ) {
                                _e( 'No comments found in Trash.' );
                        } else {
                        _e( 'No comments found.' ); }
                }
        }

[Presskopp]

this could be leading to a working patch..

[Presskopp]

trying to meet the coding standards

[Presskopp]

failed - try again

[Presskopp]

Refreshing (and testing)

[audrasjb]

I tested the patch: it works fine and it still applies cleanly on my side.
Thanks for the ticket and the patch!

Marking for commit.

[SergeyBiryukov]

In 47234:

Administration: Standardize "found in Trash" messages.

Props Presskopp, audrasjb.
Fixes #38669.