#38674 closed enhancement (fixed)
Semantic elements for non-link links: update-core.php (show/hide hidden updates)
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.1 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Administration | Keywords: | semantic-buttons has-patch has-screenshots commit |
Focuses: | ui, accessibility, javascript | Cc: |
Attachments (3)
Change History (14)
This ticket was mentioned in Slack in #accessibility by afercia. View the logs.
8 years ago
This ticket was mentioned in Slack in #accessibility by audrasjb. View the logs.
7 years ago
#9
@
7 years ago
- Keywords commit added
- Owner set to afercia
- Status changed from new to assigned
Looking back at this, I think the link should be a button and also look like a button. There's no reason why it should look like a link, as it just toggles the visibility of the hidden updates container.
38674.diff also adds an aria-expanded
attribute, improves the distance between the buttons, and fixes the toggle animation "jump" due to the top margin on the animated div.
Some testing would be nice.
Screenshot:
Note: See
TracTickets for help on using
tickets.
Much like #38671, I'll make two patches. One that relies on
.button-link
and one that's its own entity with styles included.