WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 3 years ago

#38676 closed enhancement (duplicate)

Semantic elements for non-link links: class-wp-comments-list-table.php

Reported by: Cheffheid Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Administration Keywords: semantic-buttons has-patch
Focuses: ui, accessibility, javascript Cc:

Description

Some of the items in the row actions of each comment (inline reply and quick edit specifically) should be changed to buttons here.

Attachments (2)

39676.patch (1005 bytes) - added by Cheffheid 4 years ago.
Markup only.
38676.1.patch (2.0 KB) - added by Cheffheid 4 years ago.
Markup and button styles.

Download all attachments as: .zip

Change History (9)

@Cheffheid
4 years ago

Markup only.

@Cheffheid
4 years ago

Markup and button styles.

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


4 years ago

#3 @afercia
4 years ago

  • Milestone changed from Awaiting Review to Future Release
  • Version trunk deleted

#4 @afercia
4 years ago

  • Keywords semantic-buttons added

#5 @Cheffheid
4 years ago

  • Keywords has-patch added

It's probably worth noting here (based on the Slack note) that the Quick Edit link is hidden when JavaScript is disabled. Unhiding it and linking it to the edit page instead makes it a bit redundant (since the "regular" Edit link is also there).

The "markup only" patch still applies fine for me, and with the button-link changes already in core everything looks ready for review to me too.

After patch screenshot:
https://cldup.com/1XNtZqEq-C-3000x3000.png

Last edited 4 years ago by Cheffheid (previous) (diff)

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


3 years ago

#7 @afercia
3 years ago

  • Milestone Future Release deleted
  • Resolution set to duplicate
  • Status changed from new to closed

Closing in favor of #43376, sorry for the confusion with duplicate tickets.

Note: See TracTickets for help on using tickets.