Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#38684 closed enhancement (fixed)

Improve the tab character width in the Plugins and Themes editor

Reported by: afercia's profile afercia Owned by: afercia's profile afercia
Milestone: 4.8 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-screenshots has-patch commit
Focuses: Cc:

Description

In #38667 the Customizer is going to introduce the CSS property tab-size for the Custom CSS textarea. It allows to specify a value, for example an integer for the number of spaces, to represent the width of a tab character.

The Plugins and Themes editor could use this property as well, to enhance the visual presentation of the code indentation within the editor. At the moment Firefox needs the prefixed version and there's no support in IE or Edge.

Screenshot before:

https://cldup.com/x0QnpQp3Pj.png

and after setting tab-size: 4:

https://cldup.com/4PctiYo0yY.png

Attachments (2)

38684.diff (352 bytes) - added by afercia 8 years ago.
38684.2.diff (370 bytes) - added by afercia 8 years ago.

Download all attachments as: .zip

Change History (6)

@afercia
8 years ago

#1 @afercia
8 years ago

  • Keywords has-patch added

The proposed patch just sets the tab-size to 4 and removes the outline declaration, since it's already set in forms.css for all the textarea elements.

#2 @afercia
8 years ago

  • Milestone changed from Awaiting Review to 4.8
  • Owner set to afercia
  • Status changed from new to assigned

@afercia
8 years ago

#3 @afercia
8 years ago

  • Keywords commit added

Refreshed patch: Autoprefixer still wants the -o- prefixed version for Opera 12.1.

#4 @SergeyBiryukov
8 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 39897:

Administration: Improve tab character width in Plugins and Themes editor.

Props afercia.
Fixes #38684.

Note: See TracTickets for help on using tickets.