WordPress.org

Make WordPress Core

Opened 13 months ago

Closed 13 months ago

Last modified 13 months ago

#38685 closed defect (bug) (fixed)

Replace custom CSS placeholder with default value

Reported by: westonruter Owned by: westonruter
Milestone: 4.7 Priority: normal
Severity: normal Version:
Component: Customize Keywords: has-patch has-screenshots
Focuses: Cc:

Description

As raised by @afercia in #38667:

I was staring at the comment used in the placeholder and trying to use the keyboard to select/cancel what initially appeared to me being text... was wondering why the arrow keys weren't working at all. Maybe it's just me being a bit slow :) Since it's formatted like an inline comment /* */ it looks like actual code that can be selected. Maybe potentially confusing for users, I'd consider to remove the /* */.

Attachments (2)

38685.0.diff (2.6 KB) - added by westonruter 13 months ago.
default-value-instead-of-placeholder.png (64.7 KB) - added by westonruter 13 months ago.

Download all attachments as: .zip

Change History (9)

#1 @westonruter
13 months ago

  • Keywords has-patch ui-feedback added

@melchoyce thoughts on this?

#2 follow-up: @helen
13 months ago

Default value makes sense to me; may want to take the /* */ out of the translated string itself since it needs to remain a comment.

#3 in reply to: ↑ 2 @melchoyce
13 months ago

Replying to helen:

Default value makes sense to me

+1

#4 follow-up: @lukecavanagh
13 months ago

@westonruter

I do not get the point of having a default value.

#5 @westonruter
13 months ago

  • Owner set to westonruter
  • Resolution set to fixed
  • Status changed from new to closed

In 39151:

Customize: Move Custom CSS control placeholder help text to setting default value.

The WP_Customize_Custom_CSS_Setting::value() method now returns the default if wp_get_custom_css() returns empty.

Props westonruter, afercia, helen.
See #35395.
Fixes #38685.

#6 @westonruter
13 months ago

  • Keywords has-screenshots added; ui-feedback removed

#7 in reply to: ↑ 4 @westonruter
13 months ago

Replying to lukecavanagh:

@westonruter

I do not get the point of having a default value.

The point is what @afercia raised in the description, where he expected to be able to select it. There is help text appearing in the Custom CSS textarea like this both in Jetpack and on WordPress.com.

Note: See TracTickets for help on using tickets.