Empty Post Attributes meta box showing for all post types when using a child theme

[justinbusa]

This only happens when testing 4.7 beta.

When I have a vanilla child theme installed (no additional code aside from style.css), I'm seeing an empty Post Attributes box on the edit screen for all post types.

When I switch to a parent theme, the issue goes away.

The issue appears with twenty* child themes as well. All plugins have been deactivated.

[ocean90]

Related: [38951]

[swissspidy]

Hey there,

Thanks for your report!

Even though I'm pretty sure to have triple-checked, this likely was introduced in #18375 / [38951]. I'll try to reproduce in a few and come up with a patch.

[justinbusa]

Thanks! I did some testing and it looks like adding the $post variable to the get_page_templates( $post, $post_type ); call in edit-form-advanced.php fixes the issue.

[swissspidy]

@justinbusa Good catch. This line revealed that \WP_Theme::get_page_templates() isn't passing the $post_type when checking for templates of the parent theme, causing a false positive.

38696.diff​ adds a test for checking templates of a child theme.

[lukecavanagh]

@swissspidy 

The patch fixed the issue.

[lukecavanagh]

Post Edit - Attributes Showing

[swissspidy]

In 39168:

Posts, Post Types: Fix post type templates with child themes.

After [38951] added support for post type templates beyond pages, this fixes an issue where an empty meta box would be shown when using child themes.

Fixes #38696.

[jorbin]

In 39170:

Posts, Post Types: Fix themes tests broken in [39168]

[39168] introduced a new theme to the tests, but it wasn't taken into account in Tests_Theme_ThemeDir::test_theme_list.

See #38696.