WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #38700, comment 11


Ignore:
Timestamp:
11/08/2016 11:11:02 PM (3 years ago)
Author:
jnylen0
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #38700, comment 11

    initial v1  
    11> I disagree that discarding the return value is a viable option here, it's not.
    22
    3 Can you elaborate, please?  There are no other possible return paths from `wp_update_comment`.
     3Can you elaborate, please?  There are no other possible return paths from `wp_update_comment`, other than those 2 error conditions which are checked and tested in [attachment:38700.4.diff].
    44
    55I really don't care how this is fixed, but it's a pretty nasty bug in the API and needs to go in 4.7.