WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#38712 closed defect (bug) (fixed)

Button "Choose from the most used tags" is centerd

Reported by: f.staude Owned by: afercia
Milestone: 4.8 Priority: normal
Severity: normal Version: 4.7
Component: Editor Keywords: has-patch
Focuses: ui Cc:
PR Number:

Description

The button "Choose from the most used tags" is centerd when the string is to long for one row.
In the german translation the string "Wähle aus den meistgenutzten Schlagwörter" uses to rows so the button is centerd.

Attachments (5)

tags_en.png (30.3 KB) - added by f.staude 3 years ago.
Dialog en
tags_de.png (36.0 KB) - added by f.staude 3 years ago.
Dialog de
38712.diff (354 bytes) - added by f.staude 3 years ago.
CSS patch
38712.2.diff (291 bytes) - added by Presskopp 3 years ago.
38712.3.diff (351 bytes) - added by Presskopp 3 years ago.

Download all attachments as: .zip

Change History (14)

@f.staude
3 years ago

Dialog en

@f.staude
3 years ago

Dialog de

@f.staude
3 years ago

CSS patch

#1 @f.staude
3 years ago

  • Keywords has-patch needs-testing added

#2 @karmatosed
3 years ago

  • Milestone changed from Awaiting Review to Future Release

Thanks for this and the patch @f.staude - looks to me like this would make an excellent ticket to be included in a future release.

I agree with the idea of text-aligning left to fix this. I do wonder, is this the only place that has the issue? I'm wondering if any other links like this do.

#3 @f.staude
3 years ago

It is the only place we have seen that is changed from a a href in 4.6 to a button tag in 4.7

#4 @Presskopp
3 years ago

It's not the only place this could happen looking at the code, but will be the only place where it can happen, because it's a longer string. Other occurences of <button class="button-link" type="button"> are like "Update now", which in most languages should not produce breaking lines (but I don't know). Another occurence of the example is to be seen in "Press this", btw.
So I wonder if we better patch .button-link with text-align: left; instead of just the tagcloud related .tagcloud-link.button-link.

@Presskopp
3 years ago

@Presskopp
3 years ago

#5 @Presskopp
3 years ago

path corrected - I tested it locally and I see no bad sides of it.

#6 @afercia
3 years ago

  • Component changed from Posts, Post Types to Editor
  • Milestone changed from Future Release to 4.8

#7 @afercia
3 years ago

  • Owner set to afercia
  • Status changed from new to assigned

#8 @afercia
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 40059:

Buttons: Fix a few .button-link glitches after [40052].

Removes some stray underlines. Explicitly set the button text to be left aligned.

Props Cheffheid, f.staude, Presskopp.

See #34242.
Fixes #35126, #38712.

#9 @afercia
3 years ago

  • Keywords needs-testing removed
Note: See TracTickets for help on using tickets.