Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#3872 closed defect (bug) (fixed)

Some places which are not gettexted

Reported by: teknoseyir Owned by: rob1n
Milestone: 2.2 Priority: normal
Severity: normal Version: 2.1.1
Component: Administration Keywords: has-patch 2nd-opinion
Focuses: Cc:


In /wp-admin/edit.php on line 180:

> g:i:s a

But in .pot file it is gettexted like that: Y-m-d \<\b\r \/\> g:i:s a

On line 156, in /wp-admin/edit-comments.php

<p><?php comment_date('M j, g:i A'); ?> &#8212; [

is not gettexted.

And also, in Users menu, if we have users that are listed in more than one page;
the text on the next/previous pages' buttons remains English:

These are: "Next Page" and "Previous Page"

Attachments (1)

3872.diff (539 bytes) - added by rob1n 9 years ago.

Download all attachments as: .zip

Change History (10)

#1 @markjaquith
9 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4944]) i18n-inate Next Page/Previous Page for User Search. Props teknoseyir. fixes #3872

#2 @markjaquith
9 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Okay, that's part of it. The other one is a little trickier. First, it's being passed to _() which doesn't do anything. Second, putting the <br /> in the_time() like that is clunky. We need a better solution.

#3 @rob1n
9 years ago

We could do:

<?php the_time(('Y-m-d')); echo '<br />'; the_time(('g:i:s a')); ?>


<?php echo get_the_time(('Y-m-d')) . '<br />' . get_the_time(('g:i:s a')); ?>

#4 @rob1n
9 years ago

Okay... Trac messes up the formatting. Just imagine that the underlined parts are surrounded by the gettext function.

#5 @yskin
9 years ago

Line 180 in /wp-admin/edit.php is:

the_time(_('Y-m-d \<\b\r \/\> g:i:s a'));

.pot file is not error.

Just replace _() to (), it can be translated.

The first and second bugs is also be reported in ticket #3863.

#6 @foolswisdom
9 years ago

  • Milestone changed from 2.1.3 to 2.2

#7 @rob1n
9 years ago

  • Keywords has-patch 2nd-opinion added; translation gettext removed
  • Owner changed from anonymous to rob1n
  • Status changed from reopened to new

So somewhere along the line _ was turned into .

My patch splits it up and puts the <br /> in between the gettexted date formats.

9 years ago

#8 @Nazgul
9 years ago

Can we assume that its always date<br>time? Are there regional settings which do time<br>date?

#9 @rob1n
9 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Let's just leave the <br /> in.

Note: See TracTickets for help on using tickets.