WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#38722 closed defect (bug) (fixed)

Twenty Seventeen: Customizer preview display issues in IE9

Reported by: laurelfulford Owned by: laurelfulford
Milestone: 4.7 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

When previewing the static front page of the theme using IE9, the header image displays very large and zoomed in:

https://cldup.com/ZgYr5OygHJ.thumb.jpg

This is an issue with how IE9 understands vh when inside of an iframe. Normally IE9 will understand vh as the vertical height relative to the viewport, but in an iframe, IE9 thinks the vertical height is relative to the size of the whole page.

Attachments (1)

38722.patch (2.3 KB) - added by laurelfulford 4 years ago.

Download all attachments as: .zip

Change History (5)

#1 @davidakennedy
4 years ago

  • Milestone changed from Awaiting Review to 4.7
  • Owner set to laurelfulford
  • Status changed from new to assigned

@laurelfulford
4 years ago

#2 @laurelfulford
4 years ago

  • Keywords has-patch added

Created some IE9-specific styles in 38722.patch that are only loaded in the Customizer. They use pixels to set the height of the custom header and panels, rather than vh.

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


4 years ago

#4 @davidakennedy
4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 39215:

Twenty Seventeen: Fix Customizer preview display issues in IE9

IE9 doesn't understands vh (vertical height) when inside of an iframe. Normally IE9 will understand vh as the vertical height relative to the viewport, but in an iframe, IE9 thinks the vertical height is relative to the size of the whole page. So this fixes that when the site is viewed in the Customizer preview – an iframe.

Props laurelfulford.

Fixes #38722.

Note: See TracTickets for help on using tickets.