WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#38725 closed defect (bug) (fixed)

Remove 'site-lookup' global cache group

Reported by: johnjamesjacoby's profile johnjamesjacoby Owned by: jeremyfelt's profile jeremyfelt
Milestone: 4.8 Priority: normal
Severity: normal Version: 3.0
Component: Cache API Keywords: has-patch
Focuses: multisite Cc:

Description

After a bit of sleuthing around the old WordPressMU codebase, it appears the site-lookup global cache group was never put to use in core.

I pinged @dd32, who confirmed that it also is not used on WordPress.com, and I checked WordPress.org to be certain there's nothing unique happening there either.

I didn't find anything in the plugins repository using it, nor anything on GitHub.

Recommend to remove this global cache group completely from core.

Patch imminent.

Attachments (1)

38725.patch​ (3.9 KB) - added by johnjamesjacoby 7 years ago.
Remove site-lookup global cache group

Download all attachments as: .zip

Change History (3)

@johnjamesjacoby
7 years ago

Remove site-lookup global cache group

#1 @jeremyfelt
7 years ago

  • Milestone changed from Awaiting Review to 4.8
  • Owner set to jeremyfelt
  • Status changed from new to assigned

Introduced in ​mu477 and quite possibly never used. :)

#2 @jeremyfelt
7 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 40347:

Multisite: Remove unused site-lookup global cache group.

The site-lookup group was introduced in WPMU, but never actually used in WordPress core.

Props johnjamesjacoby.
Fixes #38725.

Note: See TracTickets for help on using tickets.