WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 7 months ago

#38730 new defect (bug)

XML-RPC: Edit post type templates

Reported by: swissspidy Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 4.7
Component: XML-RPC Keywords: has-patch has-unit-tests
Focuses: Cc:
PR Number:

Description

#18375 made page templates available for all post types. #38698 reflected this in the REST API. Now, we need to do the same in the XML-RPC API.

We should be able to edit the templates for any post type.

There's also the wp.getPageTemplates method, but I'm not sure yet how adding post type support would look like there.

Attachments (1)

38730.diff (2.7 KB) - added by swissspidy 3 years ago.

Download all attachments as: .zip

Change History (7)

@swissspidy
3 years ago

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


3 years ago

#2 @helen
3 years ago

Who's owning this?

#3 @swissspidy
3 years ago

I could own it as I've provided the patch and opened the ticket, but there's not much more that I could bring to it right now.

It would be great if @dd32 could review this, as he has looked at XML-RPC stuff in the past.

#4 @dd32
3 years ago

I've glanced through the patch and it looks probably correct, however looking at the patch, I don't see anything that tells clients what templates it can assign to each post type, or validation that it's an actual template specified.

Testing XML-RPC is not exactly fun, and not something I do willingly.. and wouldn't be a real-world test, only that the logic seems to work - ie. I'm not the right person to test this.

I don't personally see benefit in adding features (this is an enhancement to me) to XML-RPC which we've been ignoring for quite some time, I'd be fine with this landing in 4.8 or "use the rest api" as a resolve here.

#5 @swissspidy
3 years ago

  • Milestone changed from 4.7 to Future Release

Thanks for your feedback! I'm fine with moving this out of the milestone then.

#6 @markoheijnen
3 years ago

Thanks for creating the ticket and yes it's more an enhancement then a bug. But I will look into it for 4.8 as I do believe keeping updates to the XML-RPC is a good thing to do.

Note: See TracTickets for help on using tickets.