WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#38748 closed enhancement (fixed)

Improved documentation of image-edit.js

Reported by: jjcomack's profile jjcomack Owned by: adamsilverstein's profile adamsilverstein
Milestone: 4.8 Priority: normal
Severity: normal Version: 4.7
Component: Media Keywords:
Focuses: javascript, docs Cc:

Description

Please give props to andizer and rensw90.

Attachments (2)

image-edit.diff​ (19.2 KB) - added by jjcomack 8 years ago.
38748.diff​ (19.2 KB) - added by adamsilverstein 8 years ago.

Download all attachments as: .zip

Change History (8)

@jjcomack
8 years ago

@adamsilverstein
8 years ago

#1 @adamsilverstein
8 years ago

@jjcomack Thanks for your work on this (and thanks to @andizer and @rensw90 as well)!

38748.diff​ includes some slight cleanup, added a few missing periods and fixed a few tiny grammar issues (a -> an).

#2 @jjcomack
8 years ago

@adamsilverstein Oh thanks. I overlooked those things!

This ticket was mentioned in ​Slack in #core by helen. ​View the logs.
8 years ago

#4 @helen
8 years ago

  • Milestone changed from Awaiting Review to 4.8
  • Owner set to adamsilverstein
  • Status changed from new to assigned
  • Type changed from defect (bug) to enhancement

#5 @adamsilverstein
8 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 39493:

Docs: Add inline documentation for image-edit.js.

Adds JSDoc DocBlocks to the imageEdit methods.

Props: andizer, rensw90.
Fixes #38748.

#6 @SergeyBiryukov
8 years ago

In 39740:

Docs: Use 3-digit, x.x.x style semantic versioning for @since entries in wp-admin/js/image-edit.js.

See #38748.

Note: See TracTickets for help on using tickets.