Twenty Seventeen: JavaScript coding standards

[afercia]

All the Twenty Seventeen JavaScript files, excluding third party files, should be checked for proper ​coding standards.

A few things noticed so far:

• proper indentation
• mixed tabs and spaces
• missing space between if and brace (one occurrence)
• double spaces

Details, but I guess it's important to show best practices and enforce the usage of coding standards.

[afercia]

Also, not sure there's the need for jscs comments like // jscs:disable or // jscs:enable, unless I'm missing something.

[sstoqnov]

Not sure if html5.js is third party file or it should be changed too

[sstoqnov]

Fix wrong indentation added in 38752.diff

[afercia]

Expanding on @sstoqnov patch, I'd avoid code refactoring and just apply some coding standards.

Worth noting couple things, even if they're outside the scope of this ticket:

• some ternary and if/else seem not necessary to me, especially when setting attributes, maybe code could be simplified a bit
• in global.js and navigation.js, maybe the functions called on window resize could benefit from abstracting the function that sets the resize timer and use a custom event, as 'wp-window-resized' does in the admin, see wp-admin/js/common.js

[afercia]

Refreshed patch, see:
​Spacing for Arrays and Function Calls (Exceptions)
​Chained Method Calls

Applied changes where it seemed reasonable to me, any feedback welcome.

[davidakennedy]

@afercia This looks good to me. Thank you for going through the files and making them better!

I would be open to the changes you noted in 3, but it's probably best in another ticket. These things may also be able to be changed later since they shouldn't change the functionality.

I can work on committing this tomorrow as long as you're good with everything.

[afercia]

Replying to davidakennedy:

I can work on committing this tomorrow as long as you're good with everything.

@davidakennedy thanks, sure :)

[davidakennedy]

In 39221:

Twenty Seventeen: Make sure theme JavaScript follows proper coding standards

Props sstoqnov, afercia.

Fixes #38752.