WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#38763 closed defect (bug) (fixed)

Multisite sign-up notifications missing user login

Reported by: johnjamesjacoby Owned by: ocean90
Milestone: 4.7 Priority: high
Severity: normal Version: 4.7
Component: I18N Keywords: has-patch commit
Focuses: multisite Cc:

Description

When signing up as a multisite user (with or without blog) notification emails no longer include the user's login.

The following debug notice is triggered:

Catchable fatal error: Object of class WP_User could not be converted to string in /srv/www/wordpress-develop/src/wp-includes/ms-functions.php on line 942

See #26511, #29783.

Patch imminent.

Attachments (2)

38763.patch (1.1 KB) - added by johnjamesjacoby 5 years ago.
Prevent overriding the $user string variable with a WP_User object
38763.2.patch (6.7 KB) - added by ocean90 5 years ago.

Download all attachments as: .zip

Change History (6)

@johnjamesjacoby
5 years ago

Prevent overriding the $user string variable with a WP_User object

#1 @johnjamesjacoby
5 years ago

  • Keywords has-patch commit added

This ticket was mentioned in Slack in #meta-i18n by jjj. View the logs.


5 years ago

#3 @ocean90
5 years ago

  • Owner set to ocean90
  • Status changed from new to accepted

@ocean90
5 years ago

#4 @ocean90
5 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 39203:

Multisite: Rename the $user parameter to $user_login in wpmu_signup_blog_notification() and wpmu_signup_user_notification().

[38961] added a $user = get_user_by( 'login', $user ); call which was overriding the $user string variable for the login name. The change to $user_login makes this clear.

Props johnjamesjacoby.
Fixes #38763.

Note: See TracTickets for help on using tickets.