Post type templates ignore the last post type if there is a trailing full stop.

[peterwilsoncc]

Trailing full stops can cause the template post type comment to ignore the final post type.

// Works
Template post type: page, post

// Fails
Template post type: page, post.

Incoming patch modifies the regular expression to exclude any trailing full stops and trailing whitespace.

[peterwilsoncc]

Missed it by this much... :0

[peterwilsoncc]

Unit tests added in 38766.2.diff​.

After a second opinion, is regex's u modifier bad for performance?

[pento]

Some things:

• If we're going to change how this works, I think the correct way would be to use sanitize_key() on the post type, the same as register_post_type() does. So, instead of $type = trim( $type );, have $type = sanitize_key( $type );. That removes the need for changing the regex.
• The tests don't test for trailing spaces. The tests could probably be expanded to test for other invalid characters.
• The U modifier (invert greediness) is not the same as the u modifier (UTF-8 compatibility). The former is incorrect, and we don't need to use the latter, as only a subset of ASCII characters are allowed in post types.

[peterwilsoncc]

@pento thanks for the regex explanation.

In 38766.3.diff​:

• additional tests for trailing punctuation and white space.
• switch to sanitize_key()
• test to ensure invalid character ignored.

[pento]

:thumbs-up:

[peterwilsoncc]

In 39236:

Posts, Post Types: Improve sanitisation of templates' post types.

Prevents post type templates ignoring post types due to invalid characters. Each entry in the Template Post Type comment is run through sanitize_key() to match the sanitisation used by register_post_type().

Fixes #38766.