WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#38770 closed defect (bug) (fixed)

Business info strings should have context

Reported by: iseulde's profile iseulde Owned by: helen's profile helen
Milestone: 4.7 Priority: high
Severity: normal Version: 4.7
Component: Themes Keywords: good-first-bug needs-patch
Focuses: Cc:

Description

See https://core.trac.wordpress.org/browser/trunk/src/wp-includes/theme.php?marks=1792#L1787

Other languages seem to literally translating "Hours" etc.

Attachments (1)

38770.diff​ (4.2 KB) - added by helen 8 years ago.

Download all attachments as: .zip

Change History (7)

#1 @iseulde
8 years ago

  • Keywords i18n-change added
  • Milestone changed from Future Release to 4.7

#2 @helen
8 years ago

Seems like maybe we should add a context for all of the theme starter content strings, since that's pretty different from admin context? I should probably not have made all that stuff available for translation right away but it's good to be catching these things now :)

This ticket was mentioned in ​Slack in #meta-i18n by presskopp. ​View the logs.
8 years ago

#4 @johnbillion
8 years ago

In addition, Hours ought to be changed to something more appropriate such as Opening Hours.

#5 @ocean90
8 years ago

  • Keywords needs-patch added; i18n-change removed
  • Priority changed from normal to high

+1 for adding context to all of them. This should be done before string freeze, thus the i18n-change keyword isn't required yet.

@helen
8 years ago

#6 @helen
8 years ago

  • Owner set to helen
  • Resolution set to fixed
  • Status changed from new to closed

In 39231:

Theme starter content: Add context to all strings.

fixes #38770.

Note: See TracTickets for help on using tickets.