WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #38778, comment 6


Ignore:
Timestamp:
11/14/2016 08:42:02 PM (3 years ago)
Author:
joemcgill
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #38778, comment 6

    initial v1  
    33However, if I'm understanding the issue correctly, this is stating that we should only show the customizer controls on pages where the video could actually be active. If that is the case, then @flixos90 is correct, that the same callback we're discussing in #38738 should be used for both purposes unless there are technical reasons not to.
    44
    5 I wonder, however if it would be a weird user experience to see a "Header Image" panel on internal pages and "Header Visuals" on the front page. Would it be better to disable the controls but still show them on pages where the video won't be shown?
     5I wonder, however if it would be a weird user experience to see a "Header Image" panel on internal pages and "Header Media" on the front page. Would it be better to disable the controls but still show them on pages where the video won't be shown?