WordPress.org

Make WordPress Core

Opened 4 months ago

Last modified 4 months ago

#38796 new defect (bug)

Customize media control button labels should automatically reflect the specified mime type

Reported by: celloexpressions Owned by:
Milestone: 4.8 Priority: normal
Severity: normal Version: 4.7
Component: Customize Keywords: needs-patch
Focuses: Cc:

Description

[39234] updated the button labels for the header video control to reflect that it's used for videos, rather than media in general. However, this approach only fixes this one control instance, and is something that should be brought to all media controls.

For 4.7, we should add an inline note where [39234] is referencing this ticket and explaining that in the future all media controls will default to labeling the buttons based on the mime type (and as a reminder to remove those overrides). Then, this ticket can transition to a future release/4.8 enhancement for updating the default button labels to use the mime_type where possible, and fall back to the existing defaults with media. We'll need an array of known mime types mapped to the corresponding media type labels and should be able to substitute those into each of the default button label strings in the control constructor.

Change History (2)

#1 @westonruter
4 months ago

  • Milestone changed from 4.7 to 4.8

#2 @westonruter
4 months ago

In 39237:

Customize: Only show video header controls if previewing front page; show explanatory notice when controls are hidden.

Also include todo for the header_video control's button_labels. See #38796.

Props westonruter, joemcgill, celloexpressions.
Fixes #38778.

Note: See TracTickets for help on using tickets.